I went to Egypt in 2004 and loved it. We had a police convoy whilst driving to Dahab which was a bit scary at the time.
The Australian government currently has Egypt as an orange alert, which means reconsider your need to travel and parts of Egypt are in red alert. I read the smart traveller website today out of curiosity and it sounded a bit scary. It's not a place I would take my children after reading that.